feat(backend/i18n): separate conversation and reporting language#696
Merged
rav3n11 merged 1 commit intoJun 17, 2026
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
302
to
308
|
|
||
| # close the database connections | ||
| application_db.client.close() | ||
| taxonomy_db.client.close() | ||
| userdata_db.client.close() | ||
| taxonomy_db.client.close() | ||
| metrics_db.client.close() |
There was a problem hiding this comment.
Bug: The database client taxonomy_db.client is closed twice during application shutdown because a new call to close() was added without removing the existing one.
Severity: LOW
Suggested Fix
Remove one of the two calls to taxonomy_db.client.close() in the application shutdown logic. It is recommended to remove the second, original call to maintain a clean shutdown sequence.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: backend/app/server.py#L302-L308
Potential issue: During the application shutdown sequence, the
`taxonomy_db.client.close()` method is called twice. A new call was introduced near the
beginning of the shutdown process, but the original call further down was not removed.
This results in a redundant operation. The sequence of calls is
`application_db.client.close()`, `taxonomy_db.client.close()`,
`userdata_db.client.close()`, `taxonomy_db.client.close()`, `metrics_db.client.close()`.
While this may not cause an immediate crash, it's unnecessary and could lead to
unexpected behavior depending on the client's implementation of `close()`.
Did we get this right? 👍 / 👎 to inform future reviews.
irumvanselme
force-pushed
the
feat/backend-separate-conversation-and-report-locales
branch
from
7451319 to
4f3c747
Compare
irumvanselme
force-pushed
the
feat/backend-separate-conversation-and-report-locales
branch
from
4f3c747 to
f5e4308
Compare
rav3n11
deleted the
feat/backend-separate-conversation-and-report-locales
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(backend/server): ensure taxonomy_db connection is properly closed on shutdown
Fixes